Add allowSpecialUseDomain - tough-cookie 4.0.0 support #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently tough-cookie changed the way the
findCookies
method works slightly. It now allowsallowSpecialUseDomain
to be passed, which messes up file-cookie-store when you try to use it since it expects the third argument to be a callback function, causing it to throw an error on any use.I've actually just copied this new code from tough-cookie's own memstore.js file. I don't know if this robustly adds tough-cookie 4.0.0 support since I haven't tested it, but I hope it's a start at least.