Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allowSpecialUseDomain - tough-cookie 4.0.0 support #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

msikma
Copy link

@msikma msikma commented Sep 3, 2021

Apparently tough-cookie changed the way the findCookies method works slightly. It now allows allowSpecialUseDomain to be passed, which messes up file-cookie-store when you try to use it since it expects the third argument to be a callback function, causing it to throw an error on any use.

I've actually just copied this new code from tough-cookie's own memstore.js file. I don't know if this robustly adds tough-cookie 4.0.0 support since I haven't tested it, but I hope it's a start at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant